GoogleCloudPlatform / gke-networking-recipes

Apache License 2.0
307 stars 86 forks source link

Update test/README.md and README.md for https, iap, and asm ingress recipe. #168

Closed sawsa307 closed 11 months ago

sawsa307 commented 11 months ago
bowei commented 11 months ago

fix the comment message spelling.

sawsa307 commented 11 months ago

David can we have a discussion on how these parameters are used and come together? Ideally, we do not require the user to provide all of these for the specific tests.

Also, for values that can be pre-determined and baked into the test itself, let's just hardcode.

Yes I agree, and most values are being hardcoded. Other than ZONE and REGION, the remaining cannot be hard-coded and should be specified by users.