GoogleCloudPlatform / gke-networking-recipes

Apache License 2.0
297 stars 84 forks source link

Refactor test/helper.sh and test/utils.go #179

Closed sawsa307 closed 8 months ago

sawsa307 commented 8 months ago
sawsa307 commented 8 months ago

/assign @bowei

sawsa307 commented 8 months ago

Don't the new files need to be sourced from the helpers.sh?

Yes they are sourced, but I think they are masked by the deletion. If you expand the change in test/helper.sh, at the bottom you can find:

for f in $(find test/helpers -name *.sh); do
    source ${f}
done
bowei commented 8 months ago

for something like a library files -- you should source them explicitly instead of using find.