search

GoogleCloudPlatform / go-endpoints

Cloud Endpoints for Go
https://go-endpoints.appspot.com
Apache License 2.0
255 stars 56 forks source link

Go 1.5 compatibility (internal/* package visibility) #101

Closed vadimsht closed 8 years ago

vadimsht commented 9 years ago

Attempting to build go-endpoints with 1.5 fails:

=> Fetching dependencies for github.com/GoogleCloudPlatform/go-endpoints/endpoints... package github.com/GoogleCloudPlatform/go-endpoints/endpoints imports google.golang.org/appengine/internal: use of internal package not allowed package github.com/GoogleCloudPlatform/go-endpoints/endpoints imports google.golang.org/appengine/internal/user: use of internal package not allowed

danjacques commented 8 years ago

Since the Go AppEngine Managed VM default runtime is now using Go 1.5, code referencing this library now will no longer build with the default runtime. Can we please get this issue resolved?

vvakame commented 8 years ago

any news? :) https://groups.google.com/forum/m/#!topic/google-appengine-go/bY_OqNw2Qzo

EVILoptimist commented 8 years ago

This is an issue on App Engine Standard as well since the update to 1.6. Application code will compile and run in dev and production environments. However, a go install or goapp install will fail. Which affects code completion in editors.

campoy commented 8 years ago

Thanks for the report and sorry for the delay, working on this now!

Note: This was not fixed previously because this package is not intended to be used from Managed VMs. Now that 1.6 got to Standard Environment it needs fixing.