GoogleCloudPlatform / go-endpoints

Cloud Endpoints for Go
https://go-endpoints.appspot.com
Apache License 2.0
255 stars 56 forks source link

oauth: Remove references to internal packages #114

Closed lorenzleutgeb closed 8 years ago

lorenzleutgeb commented 8 years ago

Fixes GoogleCloudPlatform/go-endpoints#101

campoy commented 8 years ago

Hey @crhym3, do you think this is correct?

Looks good to me, but I'm not an expert on the intricacies of oauth2.

broady commented 8 years ago

This looks reasonable to me.

campoy commented 8 years ago

Thanks @broady, I wonder why we used the proto directly on the previous code. Do you know?

I'll wait for @crhym3 to give some context and merge then.

x1ddos commented 8 years ago

LGTM Thanks for fixing this.

IIRC we used proto because User.ClientID or some other field wasn't available at the time.

lorenzleutgeb commented 8 years ago

Woah, that came as a surprise after half a year, cool! :open_mouth: @crhym3 you're welcome :smile:

broady commented 8 years ago

Checked and verified that @flowlo has signed the Google CLA.