search

GoogleCloudPlatform / go-endpoints

Cloud Endpoints for Go
https://go-endpoints.appspot.com
Apache License 2.0
255 stars 56 forks source link

Doc : update on the new context.Context #124

Closed ritoon closed 7 years ago

ritoon commented 8 years ago

After the new usage for context.Context some samples where still with endpoints.Context

odeke-em commented 7 years ago

/cc @broady

odeke-em commented 7 years ago

Luckily doc.go is already updated to use context.Context as per https://github.com/GoogleCloudPlatform/go-endpoints/blob/master/endpoints/doc.go

@ritoon perhaps can we retitle this PR to

README: use context.Context instead of endpoint.Context in examples

as well as change the commit message if possible?

s-mang commented 7 years ago

@odeke-em thanks for resurrecting this! @ritoon LGTM, except commit message should be like @odeke-em suggests. I will merge and update message myself.

Thanks!

odeke-em commented 7 years ago

Cheers @adams-sarah, and thanks @ritoon for the PR!