search

GoogleCloudPlatform / golang-samples

Sample apps and code written for Google Cloud in the Go programming language.
Apache License 2.0
4.3k stars 1.74k forks source link

run/h2c: missing repo directory in cd command #1912

Closed nwtgck closed 3 years ago

nwtgck commented 3 years ago

Hi!

I might find a wrong command in the blog.

I think cd ./run/h2c below should be cd ./golang-samples/run/h2c.

git clone https://github.com/GoogleCloudPlatform/golang-samples.git
cd ./run/h2c
gcloud beta run deploy http2-test --use-http2 --source=.

(https://cloud.google.com/blog/products/serverless/cloud-run-gets-websockets-http-2-and-grpc-bidirectional-streams)

I am not sure this issue is a proper place to report blog issues.

nwtgck commented 3 years ago

Thanks for fixing the doc. Is the command in the blog https://cloud.google.com/blog/products/serverless/cloud-run-gets-websockets-http-2-and-grpc-bidirectional-streams fixing also? I meant to report the command in the blog in the issue.