GoogleCloudPlatform / golang-samples

Sample apps and code written for Google Cloud in the Go programming language.
Apache License 2.0
4.32k stars 1.75k forks source link

feat(bigQueryv2): Add SecurityCommandCenter BigQueryExports samples #4272

Closed RajviM closed 2 months ago

RajviM commented 4 months ago

Description

Reference to https://b.corp.google.com/issues/339692211 This PR adds samples to use Create, Get, Update, Delete and List methods of SecurityCommandCenter v2 BigQueryExports.

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

snippet-bot[bot] commented 4 months ago

Here is the summary of changes.

You are about to add 5 region tags. - [securitycenter/bigqueryv2/create_big_query_export.go:17](https://github.com/RajviM/golang-samples/blob/08433d8f31d0339c1f6397c47424e009a1d293e0/securitycenter/bigqueryv2/create_big_query_export.go#L17), tag `securitycenter_create_big_query_export` - [securitycenter/bigqueryv2/delete_big_query_export.go:17](https://github.com/RajviM/golang-samples/blob/08433d8f31d0339c1f6397c47424e009a1d293e0/securitycenter/bigqueryv2/delete_big_query_export.go#L17), tag `securitycenter_delete_big_query_export` - [securitycenter/bigqueryv2/get_big_query_export.go:17](https://github.com/RajviM/golang-samples/blob/08433d8f31d0339c1f6397c47424e009a1d293e0/securitycenter/bigqueryv2/get_big_query_export.go#L17), tag `securitycenter_get_big_query_export` - [securitycenter/bigqueryv2/list_big_query_export.go:17](https://github.com/RajviM/golang-samples/blob/08433d8f31d0339c1f6397c47424e009a1d293e0/securitycenter/bigqueryv2/list_big_query_export.go#L17), tag `securitycenter_list_big_query_export` - [securitycenter/bigqueryv2/update_big_query_export.go:17](https://github.com/RajviM/golang-samples/blob/08433d8f31d0339c1f6397c47424e009a1d293e0/securitycenter/bigqueryv2/update_big_query_export.go#L17), tag `securitycenter_update_big_query_export`

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

RajviM commented 4 months ago

The kokoro checks seems to be failing on unrelated changes of this PR

muncus commented 4 months ago

The kokoro checks seems to be failing on unrelated changes of this PR

Your PR is modifying a few go.mod and go.sum files outside the scope of your change, which is running these failing tests. If you limit this change to files under securitycenter, these problematic tests will not be run, and your tests will pass.

RajviM commented 4 months ago

The kokoro checks seems to be failing on unrelated changes of this PR

Your PR is modifying a few go.mod and go.sum files outside the scope of your change, which is running these failing tests. If you limit this change to files under securitycenter, these problematic tests will not be run, and your tests will pass.

These files were modified because of some previous checks failing. The suggestion command from that (after I ran) created these modification on the files.

Should I revert these files all together ? ( I'm new to development in golang + sample)

muncus commented 3 months ago

These files were modified because of some previous checks failing. The suggestion command from that (after I ran) created these modification on the files.

Should I revert these files all together ? ( I'm new to development in golang + sample)

Yes, please revert the go.mod and go.sum changes outside of securitycenter. It is generally sufficient to run go mod tidy in the directory where you make changes, to update the nearest set of go.mod and go.sum files. (this is usually not a problem, but there are some pre-existing broken tests that need to be fixed...)

telpirion commented 2 months ago

Closed in preference of #4343