issues
search
GoogleCloudPlatform
/
golang-samples
Sample apps and code written for Google Cloud in the Go programming language.
Apache License 2.0
4.29k
stars
1.73k
forks
source link
fix: moving prompt inside sample
#4305
Closed
BigBlackWolf
closed
1 month ago
BigBlackWolf
commented
1 month ago
Description
Moved func parameter from tests to sample as local variable
Added additional call to model, to be consistent with Python samples
Checklist
[ ] I have followed
Contributing Guidelines from CONTRIBUTING.MD
[ ]
Tests
pass:
go test -v ./..
(see
Testing
)
[ ]
Code formatted
:
gofmt
(see
Formatting
)
[ ]
Vetting
pass:
go vet
(see
Formatting
)
[ ] These samples need a new
API enabled
in testing projects to pass (let us know which ones)
[ ] These samples need a new/updated
env vars
in testing projects set to pass (let us know which ones)
[ ] This sample adds a new sample directory, and I updated the
CODEOWNERS file
with the codeowners for this sample
[ ] This sample adds a new
Product API
, and I updated the
Blunderbuss issue/PR auto-assigner
with the codeowners for this sample
[ ] Please
merge
this PR for me once it is approved
Description
Checklist
go test -v ./..
(see Testing)gofmt
(see Formatting)go vet
(see Formatting)