issues
search
GoogleCloudPlatform
/
golang-samples
Sample apps and code written for Google Cloud in the Go programming language.
Apache License 2.0
4.32k
stars
1.75k
forks
source link
fix: refactoring the sample
#4314
Closed
BigBlackWolf
closed
2 months ago
BigBlackWolf
commented
3 months ago
Description
Renamed package and removed main according to
code style
Removed temperature attribute, to be consistent with other languages
Simplified the way of fetching images to more common
Moved the logic inside single function
Enabled test passing by removing skip call
Checklist
[ ] I have followed
Contributing Guidelines from CONTRIBUTING.MD
[ ]
Tests
pass:
go test -v ./..
(see
Testing
)
[ ]
Code formatted
:
gofmt
(see
Formatting
)
[ ]
Vetting
pass:
go vet
(see
Formatting
)
[ ] These samples need a new
API enabled
in testing projects to pass (let us know which ones)
[ ] These samples need a new/updated
env vars
in testing projects set to pass (let us know which ones)
[ ] This sample adds a new sample directory, and I updated the
CODEOWNERS file
with the codeowners for this sample
[ ] This sample adds a new
Product API
, and I updated the
Blunderbuss issue/PR auto-assigner
with the codeowners for this sample
[ ] Please
merge
this PR for me once it is approved
Description
Checklist
go test -v ./..
(see Testing)gofmt
(see Formatting)go vet
(see Formatting)