Closed BigBlackWolf closed 2 months ago
It appears to be two identical samples in embeddings.go and _embeddingspreview.go: generativeaionvertexai_sdk_embedding and generativeaionvertexai_text_embeddings / aiplatform_text_embeddings. Should one of them being removed?
It appears to be two identical samples in embeddings.go and _embeddingspreview.go: generativeaionvertexai_sdk_embedding and generativeaionvertexai_text_embeddings / aiplatform_text_embeddings. Should one of them being removed?
Yes, If the two samples are identical, we should remove one of them. If I had to guess, one was written when the feature was in a preview state.
Description
Checklist
go test -v ./..
(see Testing)gofmt
(see Formatting)go vet
(see Formatting)