search

GoogleCloudPlatform / golang-samples

Sample apps and code written for Google Cloud in the Go programming language.
Apache License 2.0
4.32k stars 1.75k forks source link

chore(build): bump earliest kokoro build version to go121 #4360

Closed subfuzion closed 2 weeks ago

subfuzion commented 2 months ago

Bumping earliest Kokoro test go version to go121. Bumping latest version to go123 will be submitted in a separate, forthcoming PR.

This should solve the breakage we're seeing from the go.mod version format change between 1.20 and 1.21. For example:

go: errors parsing go.mod:
/[tmpfs/src/github/golang-samples/opentelemetry/instrumentation/app/go.mod:3](https://cs.corp.google.com/piper///depot/google3/tmpfs/src/github/golang-samples/opentelemetry/instrumentation/app/go.mod?l=3):
invalid go version '1.21.0': must match format 1.23
muncus commented 2 weeks ago

This change was made in a different PR #4392 , so i think its safe to close this one. Tony, thanks for investigating this and helping us find the solution!