search

GoogleCloudPlatform / google-cloud-eclipse

Google Cloud Platform plugin for Eclipse
Apache License 2.0
86 stars 49 forks source link

Common user visible strings #170

Open elharo opened 8 years ago

elharo commented 8 years ago

We're duplicating some user visible strings across plugins. E.g. "App Engine Standard" in both AppEngineStandardWizardPage and com.google.cloud.tools.ecipse.appengine.localserver/plugin.properties/serverTypename

It would be very nice to read these from a single properties file shared across plugins somehow.

Note that the eclipse externalize strings refactoring does not fully accomplish this since it creates properties files in the same directory and plugin.

elharo commented 8 years ago

See if instead of hard coding strings we can read the wizard.name and wizard.description properties from plugins/com.google.cloud.tools.eclipse.appengine.newproject/plugin.properties

elharo commented 8 years ago

see here for reading plugin properties from the bundle:

http://stackoverflow.com/questions/3427717/how-can-i-use-properties-taken-from-a-file-in-the-code-of-an-eclipse-pde-fragmen

akerekes commented 7 years ago

Could not find a better issue, so I add it here: if org.eclipse.osgi.util is added to the Import-Package list, we can use Eclipse's externalize method instead of the getMessage() based solution.

branflake2267 commented 7 years ago

This might be of interest: http://www.eclipse.org/articles/Article-Internationalization/how2I18n.html