GoogleCloudPlatform / google-cloud-eclipse

Google Cloud Platform plugin for Eclipse
Apache License 2.0
86 stars 49 forks source link

Automatically use bare-bones app.yaml when users don't enter it in global WAR/JAR deploy dialog #2462

Open chanseokoh opened 7 years ago

chanseokoh commented 7 years ago

The global WAR/JAR deploy dialog requires users to provide a WAR/JAR file and app.yaml. The minimal app.yaml contents to make it work is

runtime: java
env: flex

In some sense, requiring an explicit app.yaml makes sense, because it is the file that describes how users want to deploy their app. In another sense, however, just assuming the minimal app.yaml when not provided will increase accessibility for beginners.

Anyway, I think we will consider only the global WAR/JAR deploy dialog, because we automatically create src/main/appengine/app.yaml when adding flex facets to projects.

UI will need tweaks to make this happen.

patflynn commented 7 years ago

doesn't gcloud already do this?

On Thu, Oct 5, 2017 at 12:01 PM, Chanseok Oh notifications@github.com wrote:

The global WAR/JAR deploy dialog requires users to give a WAR/JAR file and app.yaml. The minimal app.yaml contents to make it work is

runtime: java env: flex

In some sense, requiring an explicit app.yaml makese sense, because it is the file that describes how users wants to deploy their app. In another sense, however, just assuming the minimal app.yaml when not provided will increase accessibility for beginners.

Anyway, I think we will consider only the global WAR/JAR deploy dialog, because we automatically create src/main/appengine/app.yaml when adding flex facets to projects.

UI will need tweaks to make this happen.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/google-cloud-eclipse/issues/2462, or mute the thread https://github.com/notifications/unsubscribe-auth/AHf5HesVk03_5Pxg2O8lBUobYYjfIffgks5spP13gaJpZM4PvUe4 .

chanseokoh commented 7 years ago

Interesting. It's in Beta though. Also requires the -q switch to go non-interactive.

$ gcloud app deploy
WARNING: Automatic app detection is currently in Beta
Deployment to Google App Engine requires an app.yaml file. This
command will run `gcloud beta app gen-config` to generate an app.yaml
file for you in the current directory (if the current directory does
not contain an App Engine service, please answer "no").

Do you want to continue (Y/n)?  n
ERROR: (gcloud.app.deploy) Aborted by user.
$ gcloud app deploy -q
WARNING: Automatic app detection is currently in Beta
Writing [app.yaml] to [.../some-directory].
Services to deploy:

descriptor:      [.../some-directory/app.yaml]
source:          [.../some-directory]
target project:  [some-project]
target service:  [default]
target version:  [20171006t145452]
target url:      [https://some-project.appspot.com]

If this is your first deployment, this may take a while...done.                                                                                                                                      

Beginning deployment of service [default]...
Building and pushing image for service [default]

No matter how we enable this, the UI still needs tweaks — for example, a checkbox saying "use default(?) app.yaml" or "let Cloud SDK generate app.yaml".