Restore Dockertools in Oxygen

elharo commented 6 years ago

Oxygen should have the full Docker tools plugin.

Only Neon gets Docker editor.

elharo commented 6 years ago

Need to remove Neon support first (#3233).

briandealwis commented 6 years ago

I'm not sure how to handle referencing the Eclipse Docker Tools (which includes the Docker Editor) as they have separate versions for Oxygen and Photon. We may be lucky and the version for Photon might just work in Oxygen, but I think it unlikely and we may still have this issue with 2018-09 or beyond.

Here's a few possibilities — I think (2-2) might be best.

1. Just reference the Eclipse Docker Tools (❌ doesn't work)

Since our installation instructions directs users to install via the Eclipse Marketplace entry, I had hoped that we might be able to simply reference the Docker Tools feature (org.eclipse.linuxtools.docker.feature) from our entry and the Eclipse Marketplace would try to resolve this against the installation's current set of update sites which normally include the appropriate download.eclipse.org/releases/XXX and thus just pick up the appropriate version of the Docker Tools. But I tried it and this doesn't work:

2-1. Have an implicit reference within one of our features

We could have our .suite feature add a <requires><import feature="org.eclipse.linuxtools.docker.feature" ...>, which I think will do the right thing even from the Marketplace. But it is not optional.

2-2. Create a separate CT4E feature

We could create a separate CT4E feature (say com.google.cloud.tools.eclipse.docker.feature with a <requires><import ...>. We'd then reference this feature from the Marketplace entry.

It would help if we had some functionality to add here though. We could make this a k8s feature and add some simple .yaml templates for YEdit.

3. Have explicit per-release update sites

We currently have a single update site: https://dl.google.com/eclipse/google-cloud-eclipse/stable/.

We could instead have a separate update site for each supported Eclipse version:

where each release is a composite repository with pointers to http://download.eclipse.org/releases/XXX (XXX = oxygen, photon, 2018-09) and to https://dl.google.com/eclipse/google-cloud-eclipse/stable/.

Our Marketplace entry would then have separate solution versions for each release.

4. Just reference the Docker Tools marketplace entry

https://marketplace.eclipse.org/content/eclipse-docker-tooling

briandealwis commented 6 years ago

(4) might be the right answer. The Eclipse Docker Tools marketplace entry has a special fileExtension_Dockerfile tag which is used by Eclipse to lookup editors from the Eclipse Marketplace for unassociated files. So a user opening a Dockerfile should see a suggestion for the Docker Tools.

GoogleCloudPlatform / google-cloud-eclipse