search

GoogleCloudPlatform / google-cloud-eclipse

Google Cloud Platform plugin for Eclipse
Apache License 2.0
86 stars 49 forks source link

Button to install app-engine-java components #849

Open elharo opened 7 years ago

elharo commented 7 years ago

In the new app engine wizard flow, if java components are missing, provide a Button or Link that installs them. If successful, mark the page as valid so the user can move on with Next.

This may (or may not) require adding functionality to appengine-plugins-core to install the components. I'm tempted to not even ask the user. Just do the check and run the install if gcloud is present and the java components aren't.

patflynn commented 7 years ago

If you switch to using the maven staging artifact you won't have any cases where the user needs to explicitly install the java component.

On Wed, Oct 19, 2016 at 5:54 AM, Elliotte Rusty Harold < notifications@github.com> wrote:

In the new app engine wizard flow, if java components are missing, provide a Button or Link that installs them. If successful, mark the page as valid so the user can move on with Next.

This may (or may not) require adding functionality to appengine-plugins-core to install the components. I'm tempted to not even ask the user. Just do the check and run the install if gcloud is present and the java components aren't.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/google-cloud-eclipse/issues/849, or mute the thread https://github.com/notifications/unsubscribe-auth/AHf5HVeMrM9P1wz9fE-ct2OY1ps2cz9Bks5q1ejZgaJpZM4KaxlK .

chanseokoh commented 7 years ago

@patflynn I'm trying to understand this. If that's the case, can't the appengine-plugin-core use the maven staging artifact? Does that remove the dependency on the java component once and for all? Or, does the core plugin still need the java component for other operations that Eclipse don't support?

patflynn commented 7 years ago

Yes we can and should push this into core

I think that it does remove the explicit need to expose the existence of the component to the user.

On Tue, Oct 25, 2016 at 3:06 PM, Chanseok Oh notifications@github.com wrote:

@patflynn https://github.com/patflynn I'm trying to understand this. If that's the case, can't the appengine-plugin-core use the maven staging artifact? Does that remove the dependency on the java component once and for all? Or, does the core plugin still need the java component for other operations that Eclipse don't support?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/google-cloud-eclipse/issues/849#issuecomment-256144405, or mute the thread https://github.com/notifications/unsubscribe-auth/AHf5HSkRgsL3nKTRsh56HuRSUqiDSuozks5q3lMwgaJpZM4KaxlK .

briandealwis commented 7 years ago

Filed https://github.com/GoogleCloudPlatform/appengine-plugins-core/issues/244