GoogleCloudPlatform / google-cloud-ops-agents-ansible

Ansible Role for Google Cloud Ops
https://cloud.google.com/products/operations
Apache License 2.0
99 stars 55 forks source link

Support Ops Agent 2.0.0 #66

Closed jsirianni closed 3 years ago

jsirianni commented 3 years ago

Tested on Linux against ops agent 1.0.4 and 2.0.0 and 2.0.1. (note that 2.0.0 will fail its service test case, see this PR for the solution)

molecule create -s ops-agent-test
molecule cleanup -s ops-agent-test 
molecule converge -s ops-agent-test
molecule idempotence -s ops-agent-test 
molecule verify -s ops-agent-test

I do not like the redundant use of the "Service Name" fact, however, it was tricky to get conditional variable naming to work wirth the ops agent, which has two options (google-ops-agent and google-ops-agent.target).

I have not tested the following as my CI environment will not support them

Resolves https://github.com/GoogleCloudPlatform/google-cloud-ops-agents-ansible/issues/64

rmoriar1 commented 3 years ago

Suse 15 tests are failing will the error fatal: [ansible-sles-15-monitoring-test]: FAILED! => {"changed": false, "msg": "Unable to start service stackdriver-agent: Job for stackdriver-agent.service failed because the control process exited with error code.\nSee \"systemctl status stackdriver-agent.service\" and \"journalctl -xe\" for details.\n"}

We could consider just removing them.

sdigit commented 3 years ago

This line breaks things without an appropriate else '': https://github.com/GoogleCloudPlatform/google-cloud-ops-agents-ansible/pull/66/files#diff-1da82c578776d2f38ea47d53ecff497366ccada016e145e149c37ae061d190ffR4

qingling128 commented 3 years ago

Friendly ping.