Closed jsirianni closed 3 years ago
Suse 15 tests are failing will the error fatal: [ansible-sles-15-monitoring-test]: FAILED! => {"changed": false, "msg": "Unable to start service stackdriver-agent: Job for stackdriver-agent.service failed because the control process exited with error code.\nSee \"systemctl status stackdriver-agent.service\" and \"journalctl -xe\" for details.\n"}
We could consider just removing them.
This line breaks things without an appropriate else ''
:
https://github.com/GoogleCloudPlatform/google-cloud-ops-agents-ansible/pull/66/files#diff-1da82c578776d2f38ea47d53ecff497366ccada016e145e149c37ae061d190ffR4
Friendly ping.
service_name
, based on the service name variables invars/
ops_agent_service_name
toops-agent_service_name
, Ansible complains about naming convention when referencing the variable while setting a fact or during condition evaluation..target
as a suffix for its service name, this is handled conditionally depending on if major version1
or not.Tested on Linux against ops agent 1.0.4 and 2.0.0 and 2.0.1. (note that 2.0.0 will fail its service test case, see this PR for the solution)
I do not like the redundant use of the "Service Name" fact, however, it was tricky to get conditional variable naming to work wirth the ops agent, which has two options (
google-ops-agent
andgoogle-ops-agent.target
).I have not tested the following as my CI environment will not support them
Resolves https://github.com/GoogleCloudPlatform/google-cloud-ops-agents-ansible/issues/64