Ensure bucketCollections.CompleteAdding() is always called.

GoogleCloudPlatform / google-cloud-powershell

PowerShell cmdlets for the Google Cloud Platform

http://googlecloudplatform.github.io/google-cloud-powershell/

Apache License 2.0

135 stars 61 forks source link

Ensure bucketCollections.CompleteAdding() is always called. #595

Closed ILMTitan closed 6 years ago

ILMTitan commented 6 years ago

Fixes #594.

quoctruong commented 6 years ago

@ILMTitan LGTM.

quoctruong commented 6 years ago

@iantalarico I think that sounds good. I think sometimes I just get a little too "greedy" with what I can put in the PR. If we separate them, then it will also be easier if we want to revert a bad PR without reverting the formatting PR.