search

GoogleCloudPlatform / google-cloud-powershell

PowerShell cmdlets for the Google Cloud Platform
http://googlecloudplatform.github.io/google-cloud-powershell/
Apache License 2.0
135 stars 61 forks source link

Pull Request for Issue # 615 #616

Closed pjmcc2009 closed 6 years ago

pjmcc2009 commented 6 years ago

Pull request for issue #615

googlebot commented 6 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot commented 6 years ago

CLAs look good, thanks!

quoctruong commented 6 years ago

@pjmcc2009 Thank you for the contribution! I think we should add a Zone parameter and modify the DiskType parameter to have a ValidateSet attribute with only pd-standard, pd-ssd and local-ssd. This should cover more scenarios.

quoctruong commented 6 years ago

@pjmcc2009 Would you like me to merge the changes for you?

pjmcc2009 commented 6 years ago

@quoctruong Yeah for sure. Sorry I don't think that I have permissions to do the merge on my side.

quoctruong commented 6 years ago

@pjmcc2009 No problem! I just want to make sure that there are no additional changes that you want to check in.