search

GoogleCloudPlatform / google-cloud-visualstudio

Google Cloud Tools for Visual Studio
https://cloud.google.com/tools/visual-studio/docs/
Apache License 2.0
88 stars 51 forks source link

Update the ASP.NET Core on GCE warning message. #1066

Closed ILMTitan closed 5 years ago

ILMTitan commented 5 years ago

image

codecov[bot] commented 5 years ago

Codecov Report

Merging #1066 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
+ Coverage   49.75%   49.76%   +0.01%     
==========================================
  Files         479      479              
  Lines       11724    11727       +3     
==========================================
+ Hits         5833     5836       +3     
  Misses       5891     5891
Impacted Files Coverage Δ
...teps/CoreGceWarning/CoreGceWarningStepViewModel.cs 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e21761c...33e53c5. Read the comment docs.

ILMTitan commented 5 years ago

PTAL. Updated with a screenshot of the new warning message. After consideration, I decided auto-selecting "Don't show this warning again" was not a great idea. If someone quickly clicks through the warning, they would have no way to get back to it, and would be left wondering what it was.