search

GoogleCloudPlatform / google-cloud-visualstudio

Google Cloud Tools for Visual Studio
https://cloud.google.com/tools/visual-studio/docs/
Apache License 2.0
88 stars 51 forks source link

Ignore two tests that are flaky on AppVeyor. #1077

Closed ILMTitan closed 5 years ago

ILMTitan commented 5 years ago

TestInvokeAsync_ThrowsTaskCanceledExceptionWhenTokenCanceled and TestInvokeAsync_StopsPowerShellWhenTokenCanceled are flakey when run on AppVeyor (but not locally). Skip them on AppVeyor.

iantalarico commented 5 years ago

Before we skip them do we know why they are flaky? Is it a resource issue?

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4574750). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1077   +/-   ##
========================================
  Coverage          ?   49.4%           
========================================
  Files             ?     480           
  Lines             ?   11943           
  Branches          ?       0           
========================================
  Hits              ?    5901           
  Misses            ?    6042           
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4574750...9875275. Read the comment docs.

ILMTitan commented 5 years ago

I do not know why they are flaky. I have spent several afternoons trying to unflake them, and even made some PRs that I thought would unflake them, but never to any success.

It seems like, for some reason, on AppVeyor, PowerShell sometimes does not stop after PowerShell.Stop() is called. Instead, it runs to completion (which times out the tests).