GoogleCloudPlatform / google-cloud-visualstudio

Google Cloud Tools for Visual Studio
https://cloud.google.com/tools/visual-studio/docs/
Apache License 2.0
88 stars 51 forks source link

Support Regional GKE Clusters. #1079

Closed ILMTitan closed 5 years ago

ILMTitan commented 5 years ago

Fix a threading error when deploying to GKE. Fixes #1021

codecov[bot] commented 5 years ago

Codecov Report

Merging #1079 into master will increase coverage by 0.13%. The diff coverage is 63.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1079      +/-   ##
==========================================
+ Coverage   49.42%   49.56%   +0.13%     
==========================================
  Files         480      480              
  Lines       11951    11955       +4     
==========================================
+ Hits         5907     5925      +18     
+ Misses       6044     6030      -14
Impacted Files Coverage Δ
...sion/GoogleCloudExtension/Utils/GcpOutputWindow.cs 5.55% <ø> (+0.42%) :arrow_up:
...ension/PublishDialog/Steps/Gke/GkeStepViewModel.cs 99.41% <ø> (ø) :arrow_up:
...gleCloudExtension/GCloud/KubectlContextProvider.cs 0% <0%> (ø) :arrow_up:
...tension/GoogleCloudExtension/Utils/ProcessUtils.cs 71.83% <0%> (+11.61%) :arrow_up:
...nsion/GoogleCloudExtension/GCloud/GCloudWrapper.cs 0% <0%> (ø) :arrow_up:
...xtension/GoogleCloudExtension/Git/GitRepository.cs 0% <0%> (ø) :arrow_up:
...Extension.DataSources/ResourceManagerDataSource.cs 96.87% <100%> (ø) :arrow_up:
...nsion/GoogleCloudExtension/GCloud/GCloudContext.cs 92.45% <100%> (ø) :arrow_up:
...tension.DataSources/ServiceManagementDataSource.cs 58.62% <100%> (+1.47%) :arrow_up:
.../GoogleCloudExtension.DataSources/GkeDataSource.cs 100% <100%> (+71.42%) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e3edd6...d2acb31. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #1079 into master will increase coverage by 0.4%. The diff coverage is 81.31%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1079     +/-   ##
=========================================
+ Coverage   49.42%   49.82%   +0.4%     
=========================================
  Files         480      481      +1     
  Lines       11951    11963     +12     
=========================================
+ Hits         5907     5961     +54     
+ Misses       6044     6002     -42
Impacted Files Coverage Δ
...sion/GoogleCloudExtension/Utils/GcpOutputWindow.cs 5.55% <ø> (+0.42%) :arrow_up:
...ension/PublishDialog/Steps/Gke/GkeStepViewModel.cs 99.41% <ø> (ø) :arrow_up:
...wsCredentials/ManageWindowsCredentialsViewModel.cs 0% <0%> (ø) :arrow_up:
...nsion/GoogleCloudExtension/GCloud/GCloudWrapper.cs 0% <0%> (ø) :arrow_up:
...xtension/GoogleCloudExtension/Git/GitRepository.cs 0% <0%> (ø) :arrow_up:
...Extension.DataSources/ResourceManagerDataSource.cs 96.87% <100%> (ø) :arrow_up:
...nsion/GoogleCloudExtension/GCloud/GCloudContext.cs 93.22% <100%> (+0.76%) :arrow_up:
...tension.DataSources/ServiceManagementDataSource.cs 58.62% <100%> (+1.47%) :arrow_up:
...tension/GoogleCloudExtension/Utils/ProcessUtils.cs 97.18% <100%> (+36.96%) :arrow_up:
...Extension/Services/FileSystem/FileSystemService.cs 100% <100%> (ø) :arrow_up:
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e3edd6...991df73. Read the comment docs.