VS Themes Dependent Styles

[amanda-tarafa]

Creating this issue after fixing #809 to take a closer look at VS Themes and our self defined styles. Here's what I've found out so far.

• We have two window types, the tool windows (Cloud Explorer, Stackdriver Logs and Stackdriver Errors) and the rest which are all dialogs (as far as I can tell) and include Account Management, Publication Steps, etc.

• We have styles defined for the dialog windows, these windows are not theme dependent and are always shown with our own styles. I couldn't see any problem with these.

• The tool windows are theme dependent. Problems are because we are using some of the dialog styles on the tool windows. This works well with the light themes (our dialogs are light) but they don't work with the dark themes.

Right now, as far as I've been able to test, everything is visible, but on the tools windows we still have some styles that make things look not so good (see images).

So, three possibilities here:

1. We conform 100% to our own styles, tools windows would need to be entirely changed to our own styles. We are not theme dependent. Have 100% branding.
2. We conform 100% to themes, dialog windows would need to become theme supporting, we would need theme based styles. We don't have much branding except for the logos and maybe some other small thing. (Personally I lean to this, given that we are not building a stand alone application and the user might have actively selected a VS theme).
3. We keep it as is, self styled dialogs, theme dependent tool windows. We would probably want to fix the tool windows to make them 100% theme compatible, mainly fixing was is shown in the images.

On the images, properly themed search box and drop down from the Archive Manager extension, in green boxes. Our search box, drop down and tabs? or buttons on red boxes.

[iantalarico]

@amanda-tarafa Nice write up. Let's be sure to take a closer look at this once we get more of the other bugs fixed up.

[ILMTitan]

I would argue for option 2 as well.