Deployment related tasks should use explodedAppDirectory. Discover SystemServiceServlet either by servlet-name or servlet-class.

GoogleCloudPlatform / gradle-appengine-plugin

Gradle plugin that provides tasks for uploading, running and managing Google App Engine projects

Apache License 2.0

236 stars 60 forks source link

Deployment related tasks should use explodedAppDirectory. Discover SystemServiceServlet either by servlet-name or servlet-class. #214

Closed arskov closed 5 years ago

arskov commented 8 years ago

This pull request contains 2 major improvements. The plugin will allow to discover SystemServiceServlet either by servlet-name or servlet-class. Useful if you extend SystemServiceServlet with custom logic, for example logging, and deployment related tasks (appengineUpdateCron, appengineUpdateQueues, etc) should use explodedAppDirectory instead of source webAppSourceDirectory. It is very useful, for example, if you use placeholders in appengine-web.xml that are being filled from command line parameters. Relates to #193.

loosebazooka commented 8 years ago

I would prefer not to override the default behavior abruptly, I'm not sure existing users wont experience breakages or unexpected behavior. Perhaps a system property that says "use.output.webapp.dir" that sets webAppDirectory in WebAppDirTask to the exploded app webapp dir instead of the source folder? And then we start to slowly change the default behavior.

arskov commented 8 years ago

Thanks, for the review. See inline comments about particular cases. Let's agree about how we supply the flag "use.output.webapp.dir" about which directory to use and I'll implement.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

arskov commented 8 years ago

I signed Contributor License Agreement

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.