GoogleCloudPlatform / gradle-appengine-plugin

Gradle plugin that provides tasks for uploading, running and managing Google App Engine projects
Apache License 2.0
236 stars 60 forks source link

minor language cleanup #227

Closed elharo closed 5 years ago

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


elharo commented 8 years ago

I am a Google employee. Looks like the auto check misses that when editing via the web UI instead of a local client.

On Thu, Jan 21, 2016 at 8:20 AM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

[image: :memo:] Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

— Reply to this email directly or view it on GitHub https://github.com/GoogleCloudPlatform/gradle-appengine-plugin/pull/227#issuecomment-173566232 .

Elliotte Rusty Harold elharo@macfaq.com

patflynn commented 8 years ago

You might be able to configure the email address it uses for the commit when using the web UI.

On Thu, Jan 21, 2016 at 8:21 AM, Elliotte Rusty Harold < notifications@github.com> wrote:

I am a Google employee. Looks like the auto check misses that when editing via the web UI instead of a local client.

On Thu, Jan 21, 2016 at 8:20 AM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

[image: :memo:] Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

— Reply to this email directly or view it on GitHub < https://github.com/GoogleCloudPlatform/gradle-appengine-plugin/pull/227#issuecomment-173566232

.

Elliotte Rusty Harold elharo@macfaq.com

— Reply to this email directly or view it on GitHub https://github.com/GoogleCloudPlatform/gradle-appengine-plugin/pull/227#issuecomment-173567099 .

loosebazooka commented 8 years ago

I think you just have to include your Google email in your account settings On Jan 21, 2016 10:41 AM, "Patrick Flynn" notifications@github.com wrote:

You might be able to configure the email address it uses for the commit when using the web UI.

On Thu, Jan 21, 2016 at 8:21 AM, Elliotte Rusty Harold < notifications@github.com> wrote:

I am a Google employee. Looks like the auto check misses that when editing via the web UI instead of a local client.

On Thu, Jan 21, 2016 at 8:20 AM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

[image: :memo:] Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

— Reply to this email directly or view it on GitHub <

https://github.com/GoogleCloudPlatform/gradle-appengine-plugin/pull/227#issuecomment-173566232

.

Elliotte Rusty Harold elharo@macfaq.com

— Reply to this email directly or view it on GitHub < https://github.com/GoogleCloudPlatform/gradle-appengine-plugin/pull/227#issuecomment-173567099

.

— Reply to this email directly or view it on GitHub https://github.com/GoogleCloudPlatform/gradle-appengine-plugin/pull/227#issuecomment-173610612 .

patflynn commented 8 years ago

LGTM

elharo commented 8 years ago

I have my google.com address in my settings , though it isn't primary

loosebazooka commented 8 years ago

hrm.. maybe pull down the branch and recommit the change?

elharo commented 5 years ago

I think I can clean this up if you add me to the repo.

loosebazooka commented 5 years ago

I can add you, but we don't intend on doing any more work on this.