GoogleCloudPlatform / gradle-appengine-plugin

Gradle plugin that provides tasks for uploading, running and managing Google App Engine projects
Apache License 2.0
236 stars 60 forks source link

Request for Sanity Check (attempt at adding --generated-dir flag) #244

Closed jimhooker2002 closed 5 years ago

jimhooker2002 commented 8 years ago

I had a very quick blast at trying to add the --generated-dir flag (there's a feature request out for it + I want it).

Caveats:

1: I don't know Groovy. 2: I don't know Gradle. 3: I've not tested this yet, just hacked out something that looked 1/2 way sensible so I could get some input before I spend a bunch of time on it.

Can someone that actually knows what they are doing take a quick look at my code please? If it's going in the right direction then I'll happily go test it, tidy-up etc.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


loosebazooka commented 8 years ago

Looks pretty okay. I'd rather not modify the model at the moment though. Also You will have to sign the CLA to make contributions.