search

GoogleCloudPlatform / gradle-appengine-plugin

Gradle plugin that provides tasks for uploading, running and managing Google App Engine projects
Apache License 2.0
236 stars 60 forks source link

JSPs not supported. #276

Open VasilMitovClouway opened 7 years ago

VasilMitovClouway commented 7 years ago

I am not sure that this is a bug, or it is supposed to act this way and I'm just missing something. I was following the tutorial and tried to upload a single JSP file with gradle appengineUpdate and although all of the settings for JDK and source code target are set to be to 7/1.7, JSPs are not translated (i'm not sure im using the correct term) properly and throw java.lang.IllegalArgumentException: Class file is Java 8 but max supported is Java 7.

screenshot from 2017-02-21 09-57-27

Project works fine and deploys without a problem when the JSPs are removed and Servlets are used.

loosebazooka commented 7 years ago

The JDK is set to Java7? The jsp compiler is loaded by the underlying tooling, if you use a different Java version (java sdk 8) and set the target version (java 7), I'm not sure what the behavior for jsp compilation, but maybe it's just using java8.

VasilMitovClouway commented 7 years ago

Nah, I particularly changed the sdk from 8 to 7, I even changed the default Java path environmental variable to use Java 1.7. I was stuck on this problem for along time and I am pretty sure I tried every possible way/setting I could think of.

patflynn commented 7 years ago

@loosebazooka could be worth seeing if we can reproduce. This looks similar to an earlier Java 8 related SDK bug.