search

GoogleCloudPlatform / gradle-appengine-plugin

Gradle plugin that provides tasks for uploading, running and managing Google App Engine projects
Apache License 2.0
236 stars 60 forks source link

JSP build step not honoring bootstrap classpath #286

Open dsilvasc opened 7 years ago

dsilvasc commented 7 years ago

I'm running into the following error with the appengine sdk version 1.9.42:

08:51:02.640 [INFO] [org.gradle.process.internal.DefaultExecHandle] Starting process 'command '/Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/bin/java''. Working directory: ... Command: /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/bin/java -Dfile.encoding=UTF-8 -Duser.country=GB -Duser.language=en -Duser.variant -cp ~/.gradle/appengine-sdk/appengine-java-sdk-1.9.42/lib/appengine-tools-api.jar com.google.appengine.tools.admin.AppCfg --oauth2 --enable_jar_classes --enable_jar_splitting update $root/build/exploded-app
...
08:51:43.029 [QUIET] [system.out] INFO: Built File: /internal/some.jsp
08:51:43.318 [ERROR] [system.err] warning: [options] bootstrap class path not set in conjunction with -source 1.7

My build.gradle has source and target compatibility set to 1.7:

sourceCompatibility = '1.7'
targetCompatibility = '1.7'

and the boot classpath also set to the 1.7 runtime jars:

def bootJars = ['rt.jar', 'jsse.jar', 'jce.jar'].collect { new File("$rootDir/java7jars/$it") }

tasks.withType(JavaCompile) {
  doFirst {
    options.bootClasspath = bootJars.collect { it.path }.join(File.pathSeparator)
  }
}

All of the java compilation tasks work fine with this config, except appengine's JSP compilation step. Can you please read options.bootClasspath (or even a new option) and pass that on to the JSP compiler?

patflynn commented 7 years ago

@loosebazooka This sounds like something we need to make sure we do in our other plugins as well.

loosebazooka commented 7 years ago

I think it'll have to be handled by the appengine sdk, @ludoch ?

ludoch commented 7 years ago

Right, staging does not deal with bootclasspath....

On Tue, May 23, 2017 at 11:48 AM, Appu Goundan notifications@github.com wrote:

I think it'll have to be handled by the appengine sdk, @ludoch https://github.com/ludoch ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/gradle-appengine-plugin/issues/286#issuecomment-303495722, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE4zedFfYbvBf1HpIPSPNLaAhsM9aWeks5r8ynhgaJpZM4NjVWC .