search

GoogleCloudPlatform / gradle-appengine-plugin

Gradle plugin that provides tasks for uploading, running and managing Google App Engine projects
Apache License 2.0
236 stars 60 forks source link

Java 8 compatability #292

Closed patjackson52 closed 7 years ago

patjackson52 commented 7 years ago

When using Java 8 runtime there is an error for any classes in the old whitelist that stops deployment/local dev.

loosebazooka commented 7 years ago

Can you provide more detail?

loosebazooka commented 7 years ago

Have you tried the gcloud based plugin https://Github.com/GoogleCloudPlatform/app-gradle-plugin when using java 8?

patjackson52 commented 7 years ago

When using the Java 8 runtime withis this plugin and previously whitelisted classes, the plugin can not deploy or run local server. Appears to be due to appcfg checking the classes?

Yes, I've tried the other plugin and it does not have a plugin that allows local dev/debugging within Intellij/Android studio.

On Tue, Aug 15, 2017, 1:54 PM Appu Goundan notifications@github.com wrote:

Have you tried the gcloud based plugin https://Github.com/GoogleCloudPlatform/app-gradle-plugin when using java 8?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/gradle-appengine-plugin/issues/292#issuecomment-322540101, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgxqndjli2NRZiP-oBmWljS0tdVll1lks5sYdtngaJpZM4O35Rc .

patflynn commented 7 years ago

@patjackson52 FYI we do have a plugin for Intellij. Unfortunately no support for Android Studio at this time.

patjackson52 commented 7 years ago

I have found a hack that will work for the being. If you remove the appengine-agent.jar and appengine-agentimpl.jar from ~/.gradle/appengine-sdk/appengine-java-sdk-{version}/lib/agent/ it skip the class restriction check and run in debug just fine. Looks like this is out of the gradle plugins control and is under the Intellij plugin.

I've created a gradle tasks that renames the file on assemble tasks so other team members will not have to bother with it.

loosebazooka commented 7 years ago

The agent should only be added in when running java7 apps, which intellij plugin are you using?

pushbit commented 7 years ago

I'm using the idea plugin. Is that what controls the execution of the dev app server? patjackson52's "hack" worked for me too, but it would be nice to not have to repeat it when a new version of appengine-java-sdk is released.