search

GoogleCloudPlatform / gradle-appengine-plugin

Gradle plugin that provides tasks for uploading, running and managing Google App Engine projects
Apache License 2.0
236 stars 60 forks source link

GAE_ENV + GAE_RUNTIME #295

Open loosebazooka opened 7 years ago

elharo commented 7 years ago

Are you sure about this one? I still think this is properly the domain of dev_appserver.

loosebazooka commented 7 years ago

Since we launch the process, we have to handle it. This gradle-appengine-plugin (appcfg based) actually just calls into KickStart https://github.com/GoogleCloudPlatform/gradle-appengine-plugin/blob/master/src/main/groovy/com/google/appengine/task/RunTask.groovy#L102 so it should already be handled, but it's though a convoluted process that I'd rather not deal with in appengine-plugins-core.

ludoch commented 7 years ago

close?

loosebazooka commented 7 years ago

@ludoch handled by kickstart in this plugin already.

ludoch commented 7 years ago

Ok... I guess if you CTRL-C a run session with gradle, do you know if all processes are killed? Or maybe this is fixed now? http://bugs.java.com/bugdatabase/view_bug.do?bug_id=4770092

loosebazooka commented 7 years ago

The way the gradle plugin is written is that it's only a 2 process chain, so it's fine. It's not calling kickstart.sh : https://github.com/GoogleCloudPlatform/gradle-appengine-plugin/blob/master/src/main/groovy/com/google/appengine/task/RunTask.groovy#L102

loosebazooka commented 7 years ago

leaving open to make sure this works.

loosebazooka commented 7 years ago

this should be checked for 1.9.56