search

GoogleCloudPlatform / gradle-appengine-templates

Freemarker based templates that build with the gradle-appengine-plugin
438 stars 205 forks source link

replacing use of deprecated apache http client calls #69

Closed etanshaul closed 8 years ago

etanshaul commented 8 years ago

fixes #68

Replacing use of Apache's deprecated DefaultHttpClient with HttpClientBuilder

patflynn commented 8 years ago

LGTM

loosebazooka commented 8 years ago

I think the problem is deeper than this :

Deprecation notice : http://developer.android.com/about/versions/marshmallow/android-6.0-changes.html#behavior-apache-http-client

A possible workaround : http://stackoverflow.com/questions/29294479/android-deprecated-apache-module-httpclient-httpresponse-etc

etanshaul commented 8 years ago

I see. I didn't catch that support for the apache http client was removed altogether. I'll update this.

etanshaul commented 8 years ago

updated sample code removing all uses of the apache http client. example tested on android 6.

elharo commented 8 years ago

lgtm

loosebazooka commented 8 years ago

lgtm