search

GoogleCloudPlatform / gradle-appengine-templates

Freemarker based templates that build with the gradle-appengine-plugin
438 stars 205 forks source link

Update README.md #74

Closed futhrevo closed 8 years ago

futhrevo commented 8 years ago

Additional instructions for running on actual device to avoid ECONNREFUSED error

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

futhrevo commented 8 years ago

Signed CLA

Thanks Rakesh

On 15-May-2016, at 11:36, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/. If you signed the CLA as a corporation, please let us know the company's name. — You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/GoogleCloudPlatform/gradle-appengine-templates/pull/74#issuecomment-219268399

googlebot commented 8 years ago

CLAs look good, thanks!

loosebazooka commented 8 years ago

Thanks for this contribution, but I think it needs to be moved to another section between 2.1 and 2.2 "Testing your app on a device" or something. It also needs to be updated across all relevant Readmes for this repository.

futhrevo commented 8 years ago

Do I need to create new pull request or it will be taken care of?

loosebazooka commented 8 years ago

I can take care of it. Thanks.