GoogleCloudPlatform / gradle-appengine-templates

Freemarker based templates that build with the gradle-appengine-plugin
438 stars 205 forks source link

Update with step to initialize the AppEngine #83

Closed lamdbui closed 7 years ago

lamdbui commented 7 years ago

Google App Engine no longer automatically initializes a new project so it requires an additional manual step to initialize the new project.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


lamdbui commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

patflynn commented 7 years ago

Hi @lamdbui! Thank you for sending the fix instead of filing the bug!

lamdbui commented 7 years ago

Hi @patflynn , thanks a lot for the feedback! I made the requested changes and tested the command without the "beta" and it works fine. Let me know if there's anything else you think could be improved.

patflynn commented 7 years ago

Thanks @lambdui. I merged your change and tweaked to clarify the distinction between the console vs shell scenarios.

On Mon, Mar 6, 2017 at 11:05 AM, lamdbui notifications@github.com wrote:

Hi @patflynn https://github.com/patflynn , thanks a lot for the feedback! I made the requested changes and tested the command without the "beta" and it works fine. Let me know if there's anything else you think could be improved.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/gradle-appengine-templates/pull/83#issuecomment-284498056, or mute the thread https://github.com/notifications/unsubscribe-auth/AHf5HUXnLINNvr0u_nI14geUxbUE_AlJks5rjFj7gaJpZM4MS51g .

lamdbui commented 7 years ago

Thanks, @patflynn!