search

GoogleCloudPlatform / gsutil

A command line tool for interacting with cloud storage services.
Apache License 2.0
864 stars 331 forks source link

Migrates p12 service account authentication flow from oauth2client to google-auth. #1763

Closed googlyrahman closed 3 months ago

googlyrahman commented 3 months ago

This change migrates p12 service account authentication flow from oauth2client to google-auth. The change is required, as oauth2client depends upon openSSL for understanding .p12 format keyfiles, in newer version of openSSL they've deprecated the support for .p12 files, due to which oauth2client would throw an error as described in bug b/330533641.

Fixes b/330533641.

googlyrahman commented 3 months ago

Please make sure to verify this manually with an actual P12 file as we are skipping the tests if the library is not present, so we can't say for sure that it would work just by looking at the tests.

I've tested the following scenarios on my cloudtop, and it's working as expected https://docs.google.com/spreadsheets/d/1VJGzjMWOjsm0NVcuoik31_QL9ZRDEW2JBv0KK7K3gF8/edit?usp=sharing