GoogleCloudPlatform / gsutil

A command line tool for interacting with cloud storage services.
Apache License 2.0
872 stars 332 forks source link

Tab completion adds extra space after folder name #776

Open TV4Fun opened 5 years ago

TV4Fun commented 5 years ago

Using gsutil 4.38 with Bash, tried on Mac and Linux, gsutil ls's tab completion leaves a space after filling in a folder name. This is typically not what you want if you plan to keep typing a larger path. The behavior should mimc that of GNU command line tools like ls, that autocomplete a folder name with a / after it but no space.

catleeball commented 5 years ago

Hi @TV4Fun !

Thanks for reporting this! I was able to reproduce the issue on my machine too. I'm going to poke around the tabcomplete logic and see what happened, and also tighten up our integration tests to catch this next time. 🙂

Thanks, Lee

catleeball commented 5 years ago

Note: this appears to occur for completions on local objects, but cloud object completion doesn't seem to append the space. Opened internal issue at b/132302733

TV4Fun commented 5 years ago

Odd, I am only getting it for objects in the cloud. I haven't tried it for local objects.

On Wed, May 8, 2019, 8:46 PM Lee Ball notifications@github.com wrote:

Note: this appears to occur for completions on local objects, but cloud object completion doesn't seem to append the space. Opened internal issue at b/132302733

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/gsutil/issues/776#issuecomment-490732465, or mute the thread https://github.com/notifications/unsubscribe-auth/ABD4ECDZTLGE3FOUX2AEIQLPUONBTANCNFSM4HLWVLTQ .

catleeball commented 5 years ago

That's interesting, thanks for noting that, @TV4Fun ! Maybe cached completions? Testing some things out. 🙂

catleeball commented 5 years ago

Hi @TV4Fun ! Just keeping you posted, it looks like this is because we use gcloud SDK's completion.bash.inc file to power our completions: https://github.com/google-cloud-sdk/google-cloud-sdk/blob/master/completion.bash.inc

I'm picking around this completion file to see if we can make completion with gsutil and not break anything else in gcloud sdk, or alternatively if we should make our own completion file.

tylertroy commented 3 years ago

This is frustrating behavior, any solutions on the horizon?

$ gcloud --version
Google Cloud SDK 287.0.0
alpha 2020.03.30
beta 2020.03.30
bq 2.0.56
core 2020.03.30
gsutil 4.49
kubectl 2020.03.30
catleeball commented 3 years ago

Hey @tylertroy ! I'm working on a different team nowdays, but @NickGoog might be able to take a peek, or at least know someone who would have cycles to do so.

NickGoog commented 3 years ago

Hi, we have an open bug for the issue internally, but we're prioritizing something else that may obsolete it. Details aren't public, yet, sorry :(