search

GoogleCloudPlatform / guest-agent

Apache License 2.0
126 stars 78 forks source link

oslogin: don't remove sshca watcher when oslogin is disabled #398

Closed dorileo closed 3 months ago

dorileo commented 4 months ago

It's is innocuous to have the watcher or not enabled, we better avoid having to re-register the watcher between enable and disable cycles.

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-crate, dorileo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/guest-agent/blob/main/OWNERS)~~ [a-crate,dorileo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dorileo commented 3 months ago

/retest