Closed aschneid1 closed 3 years ago
Hi @aschneid1. Thanks for your PR.
I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
can we see some testing data for what some of these values, such as the JSON output from nvme-cli looks like and what the resulting symlinks are?
The symlinks should be "google-
{"device_name":"my-pd-test-short-name","disk_type":"PERSISTENT"}
(more fields may be added later).
do we intend to support pd-nvme for boot disks?
Yes
by symlink?
Presumably, yes. Although the behavior for boot disks shouldn't differ AFAIK.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: aschneid1, hopkiw
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This PR adds additional udev rules and a script to support disk identification for PD NVMe disks.
It requires the nvme-cli tool (updated in package configurations) and a specific vendor extension to the NVMe device/controller. The disk name will be present in this field (along with some other metadata).
It was tested in the following configurations: