GoogleCloudPlatform / guest-configs

Apache License 2.0
31 stars 41 forks source link

Updated udev rules #11

Closed aschneid1 closed 3 years ago

aschneid1 commented 3 years ago

This PR adds additional udev rules and a script to support disk identification for PD NVMe disks.

It requires the nvme-cli tool (updated in package configurations) and a specific vendor extension to the NVMe device/controller. The disk name will be present in this field (along with some other metadata).

It was tested in the following configurations:

google-oss-robot commented 3 years ago

Hi @aschneid1. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aschneid1 commented 3 years ago

can we see some testing data for what some of these values, such as the JSON output from nvme-cli looks like and what the resulting symlinks are?

The symlinks should be "google-", where pd-device-name corresponds to whatever the user chose for the device name (defaults to the guest's disk name). The json output from nvme-cli is currently experiment guarded and has to be ran in a devcluster for testing, but looks like:

{"device_name":"my-pd-test-short-name","disk_type":"PERSISTENT"}

(more fields may be added later).

do we intend to support pd-nvme for boot disks?

Yes

by symlink?

Presumably, yes. Although the behavior for boot disks shouldn't differ AFAIK.

hopkiw commented 3 years ago

/lgtm

hopkiw commented 3 years ago

/approve

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aschneid1, hopkiw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/guest-configs/blob/master/OWNERS)~~ [hopkiw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment