GoogleCloudPlatform / guest-configs

Apache License 2.0
31 stars 40 forks source link

move google_nvme_id to /usr/bin #16

Closed hopkiw closed 3 years ago

hopkiw commented 3 years ago

udev rules assume this script will be found in path, so best place it with the rest of our scripts and binaries in /usr/bin also, it wasn't being included in the package

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hopkiw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/guest-configs/blob/master/OWNERS)~~ [hopkiw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zmarano commented 3 years ago

/lgtm