GoogleCloudPlatform / guest-configs

Apache License 2.0
31 stars 40 forks source link

dracut.conf wants spaces around values #19

Closed EricEdens closed 3 years ago

EricEdens commented 3 years ago

In Fedora 33, this config file causes the warning:

dracut: WARNING: <key>+=" <values> ": <values> should have surrounding white spaces!
dracut: WARNING: This will lead to unwanted side effects! Please fix the configuration file.

When executing dracut --force in %post

EricEdens commented 3 years ago

This shows the syntax: https://man7.org/linux/man-pages/man5/dracut.conf.5.html

zmarano commented 3 years ago

Seems to be a RHEL 7-ism that was never fixed. https://bugzilla.redhat.com/show_bug.cgi?id=1392368 /lgtm

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EricEdens, zmarano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/guest-configs/blob/master/OWNERS)~~ [zmarano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment