search

GoogleCloudPlatform / guest-configs

Apache License 2.0
31 stars 41 forks source link

Update google_set_multiqueue #34

Closed xliutaox-g closed 2 years ago

xliutaox-g commented 2 years ago

In our test on xps_cpus setting, we had all CPUs striped across TX queues in the driver by default, however it resulted in throughput degradation. It had to revert back to only setting the CPUs which handles TX irq.

google-oss-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xliutaox-g To complete the pull request process, please assign zmarano after the PR has been reviewed. You can assign the PR to them by writing /assign @zmarano in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/guest-configs/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 2 years ago

Hi @xliutaox-g. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
hopkiw commented 2 years ago

/hold

hopkiw commented 2 years ago

so overall i don't think this PR is adding much value; it adds a 'be aware' comment to a very low visibility part of the guest environment. we have never had any customer outreach or feedback about this script and i doubt they will be much benefited from an additional comment. closing for now, but feel free to re-open or discuss offline if you want to add more to it.

xliutaox-g commented 2 years ago

OK. The performance test observed had 10% throughput dropping. I agree user is not likely to read the comments.