GoogleCloudPlatform / guest-configs

Apache License 2.0
31 stars 41 forks source link

Support multiple local SSD controllers. #37

Closed aswfan closed 1 year ago

aswfan commented 1 year ago

Two changes have been included in this commit:

  1. Extended google_nvme_id script to handle local SSD devices and support multiple controllers for local SSD.
  2. Updated udev rules for local SSD in 65-gce-disk-naming.rules
google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aswfan Once this PR has been reviewed and has the lgtm label, please assign adjackura for approval by writing /assign @adjackura in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/guest-configs/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 1 year ago

Hi @aswfan. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aswfan commented 1 year ago

The commit message is out-of-date. Need to be updated to avoid confusion.