GoogleCloudPlatform / guest-configs

Apache License 2.0
31 stars 41 forks source link

correcting the comment #42

Closed v-nightwolf closed 1 year ago

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: v-nightwolf Once this PR has been reviewed and has the lgtm label, please assign adjackura for approval by writing /assign @adjackura in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/guest-configs/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 1 year ago

Hi @v-nightwolf. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vorakl commented 1 year ago

Hey @v-nightwolf , thank you for filing this correction and sorry it took longer than probably anticipated.

Technically speaking, it it doesn't do both (neither new records, as we don't check them with the ones in the file, or old records, which do not exist in the script as variables at all). At that line it removes all lines which contain Added by Google, meaning were added by the google's script before.

So, if you could correct you correction ;) and make a more accurate comment, plus sign the CLA which is required to contribute into this repository, I'll be glad to merge the PR.