search

GoogleCloudPlatform / guest-configs

Apache License 2.0
31 stars 41 forks source link

set hostname: consider fully qualified static hostname #46

Closed dorileo closed 1 year ago

dorileo commented 1 year ago

The guest system may have its static hostname set with fully qualified hostname, this change make sure to only reset hostname if the static hostname is not fully qualified name and is different to the truncated new_host_name.

dorileo commented 1 year ago

For context see comments starting here: https://github.com/GoogleCloudPlatform/guest-configs/pull/44#issuecomment-1486210468

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bkatyl, dorileo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/guest-configs/blob/master/OWNERS)~~ [bkatyl,dorileo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment