GoogleCloudPlatform / guest-configs

Apache License 2.0
31 stars 41 forks source link

dracut: Add a new dracut module for gcp udev rules #53

Closed ravanelli closed 1 year ago

ravanelli commented 1 year ago
google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-oss-prow[bot] commented 1 year ago

Hi @ravanelli. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ravanelli commented 1 year ago

F.Y.I I only tested the changes for google-compute-engine.spec in F38. I didn't validate the changes for debian. Would be good if something could double check it ;) I'm not too familiar with debian packaging.

vorakl commented 1 year ago

/cc zmarano /assign zmarano

zmarano commented 1 year ago

/ok-to-test

ravanelli commented 1 year ago

/hold Still missing https://github.com/GoogleCloudPlatform/guest-configs/pull/53#discussion_r1206060777

ravanelli commented 1 year ago

/unhold Thanks all for the comments!

zmarano commented 1 year ago

/lgtm

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravanelli, zmarano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/guest-configs/blob/master/OWNERS)~~ [zmarano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment