Closed ravanelli closed 1 year ago
Hi @ravanelli. Thanks for your PR.
I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
@tytso Thanks for you suggestion in https://github.com/GoogleCloudPlatform/guest-configs/pull/49#issuecomment-1648963321. Would you mind a review to double check it?
@HuijingHei: changing LGTM is restricted to collaborators
@travier: changing LGTM is restricted to collaborators
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: HuijingHei, ravanelli, travier, zmarano
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Replace xxd with dd for google_nvme_id
google_nvme_id
script currently usesxxd
to parse nvme device info, but we need to install additional packagexxd
for fedora,vim-common
andvim-filesystem
for centos (or rhel) before using it. Replace it withdd
and we do not need to install additional packages.See https://github.com/coreos/fedora-coreos-config/pull/2412 (comment)
We initially tried to replace it with cut, creating a different result than expected. See: https://github.com/GoogleCloudPlatform/guest-configs/pull/49 Discussion about the use of
dd
vscut
.Tests for Fedora CoreOS:
Tests for Debian 12