Closed polytan closed 11 months ago
Hi @polytan. Thanks for your PR.
I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Excluding /sys/devices/virtual
seems more in line with the original filter intent than only including pci devices, and should still exclude docker's NIC. I'm not aware of any non-pci NICs that need to be included but I'm hesitant about making new assumptions without supporting reasons.
/ok-to-test
@a-crate
Do you mean doing grep -v /sys/devices/virtual
rather than grep '/sys/devices/pci'
?
Yes, exactly.
I might not expert, but will it has other type of devices here? I assume we have, but above change applies for A3 only: https://github.com/GoogleCloudPlatform/guest-configs/blob/master/src/usr/bin/google_set_multiqueue#L212
if ! is_a3_platform; then
exit
fi
A3 NICs are under PCIe switch, that's why I'm prefer grep '/sys/devices/pci'
.
Seems reasonable enough to do this only on A3. I am not an approver for this repo anyway, Leo will need to give the ok as well before merge. /lgtm
/assign @dorileo
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dorileo, polytan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
Verified there are some docker interfaces that was not excluded from the filter, this change aim to just setup IRQ for pci devices.