GoogleCloudPlatform / guest-configs

Apache License 2.0
31 stars 40 forks source link

update multinic filter to pick only pci devices #59

Closed polytan closed 11 months ago

polytan commented 12 months ago

Verified there are some docker interfaces that was not excluded from the filter, this change aim to just setup IRQ for pci devices.

google-oss-prow[bot] commented 12 months ago

Hi @polytan. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
a-crate commented 12 months ago

Excluding /sys/devices/virtual seems more in line with the original filter intent than only including pci devices, and should still exclude docker's NIC. I'm not aware of any non-pci NICs that need to be included but I'm hesitant about making new assumptions without supporting reasons.

/ok-to-test

dorileo commented 12 months ago

@a-crate

Do you mean doing grep -v /sys/devices/virtual rather than grep '/sys/devices/pci'?

a-crate commented 11 months ago

Yes, exactly.

polytan commented 11 months ago

I might not expert, but will it has other type of devices here? I assume we have, but above change applies for A3 only: https://github.com/GoogleCloudPlatform/guest-configs/blob/master/src/usr/bin/google_set_multiqueue#L212

if ! is_a3_platform; then
  exit
fi

A3 NICs are under PCIe switch, that's why I'm prefer grep '/sys/devices/pci'.

a-crate commented 11 months ago

Seems reasonable enough to do this only on A3. I am not an approver for this repo anyway, Leo will need to give the ok as well before merge. /lgtm

a-crate commented 11 months ago

/assign @dorileo

dorileo commented 11 months ago

/approve

google-oss-prow[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dorileo, polytan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/guest-configs/blob/master/OWNERS)~~ [dorileo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dorileo commented 11 months ago

/lgtm