GoogleCloudPlatform / guest-configs

Apache License 2.0
31 stars 41 forks source link

Fix tx affinity logic when number of CPUs is above 32 #6

Closed lobachpavel closed 4 years ago

lobachpavel commented 4 years ago

When the number of CPUs is above 32, affinity string must be in the form: "high-order-dword,low-order-dword", but in fact it was 'low-order-dword,low-order-dword', causing "Value too large for defined data type" errors.

Changes done to fix this:

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-oss-robot commented 4 years ago

Hi @lobachpavel. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
lobachpavel commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

hopkiw commented 4 years ago

/hold

hopkiw commented 4 years ago

/lgtm

hopkiw commented 4 years ago

/approve

google-oss-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hopkiw, lobachpavel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/guest-configs/blob/master/OWNERS)~~ [hopkiw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lobachpavel commented 4 years ago

Hi, is it going to be merged?

hopkiw commented 4 years ago

/unhold