search

GoogleCloudPlatform / guest-configs

Apache License 2.0
31 stars 41 forks source link

Add hostname hook for NetworkManager without dhclient compat script #70

Closed a-crate closed 6 months ago

a-crate commented 6 months ago

This compat script is no longer shippped in newer versions of EL9. Tested with both scripts on the same system and the second execution just overrides the first with the same (still correct) data.

This will affect other distros that use network manager too but I don't think this should be a problem. IPv4 support only, but we can fix this later.

/cc @dorileo

Fixes #69

google-oss-prow[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-crate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/guest-configs/blob/master/OWNERS)~~ [a-crate] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dorileo commented 6 months ago

do we need to update the packaging?

a-crate commented 6 months ago

do we need to update the packaging?

Yep, forgot about that. Updated.

I've included this in both deb and RPM packages even though it should be a no-op on debian, since it's consistent with the network management in GGA supporting whatever network stack the user chooses rather than just the default. We can change that if you disagree.

dorileo commented 6 months ago

/lgtm