GoogleCloudPlatform / guest-configs

Apache License 2.0
31 stars 41 forks source link

Updates the udev rules for local SSD disks. #9

Closed aschneid1 closed 4 years ago

aschneid1 commented 4 years ago

The current rules only allow for symlinks of up to 8 local SSD disks, and also rely on the NVMe controller for the local drives being labeled as nvme0*. This updates the rule to check for the appropriate model name "nvme_card", which always corresponds to the local SSD controller, rather than relying on the device name.

The additional PROGRAM element is required to 0-index the nsid so that this change doesn't alter the expected symlinks (a value of 0 for a namespace ID is invalid according to the spec).

google-oss-robot commented 4 years ago

Hi @aschneid1. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aschneid1 commented 4 years ago

/assign @hopkiw

hopkiw commented 4 years ago

/ok-to-test

hopkiw commented 4 years ago

/lgtm

hopkiw commented 4 years ago

/approve

google-oss-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aschneid1, hopkiw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/guest-configs/blob/master/OWNERS)~~ [hopkiw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment