Closed aschneid1 closed 4 years ago
Hi @aschneid1. Thanks for your PR.
I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/assign @hopkiw
/ok-to-test
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: aschneid1, hopkiw
The full list of commands accepted by this bot can be found here.
The pull request process is described here
The current rules only allow for symlinks of up to 8 local SSD disks, and also rely on the NVMe controller for the local drives being labeled as nvme0*. This updates the rule to check for the appropriate model name "nvme_card", which always corresponds to the local SSD controller, rather than relying on the device name.
The additional PROGRAM element is required to 0-index the nsid so that this change doesn't alter the expected symlinks (a value of 0 for a namespace ID is invalid according to the spec).