GoogleCloudPlatform / guest-oslogin

OS Login Guest Environment for Google Compute Engine
https://cloud.google.com/compute/docs/oslogin/
Apache License 2.0
96 stars 47 forks source link

sshca: add tests with fingerprint and multiple extensions #111

Closed dorileo closed 1 year ago

dorileo commented 1 year ago

Test fingerprint parsing with certs containing all default ssh-keygen extensions + the byoid fingerprint.

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dorileo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/guest-oslogin/blob/master/OWNERS)~~ [dorileo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ericdand commented 1 year ago

/lgtm

Thanks for adding tests!