search

GoogleCloudPlatform / guest-oslogin

OS Login Guest Environment for Google Compute Engine
https://cloud.google.com/compute/docs/oslogin/
Apache License 2.0
96 stars 47 forks source link

build: fix clang build #122

Closed gonzoua closed 12 months ago

gonzoua commented 1 year ago

Remove include/oslogin_sshca.h from the list of dependecies. It is passed to the linker command as a part of $^ variable and causes clang build error:

clang: error: clang: cannot specify -o when generating multiple output fileserror:
cannot specify -o when generating multiple output files
google-oss-prow[bot] commented 1 year ago

Hi @gonzoua. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dorileo commented 12 months ago

/lgtm

dorileo commented 12 months ago

/ok-to-test

dorileo commented 12 months ago

/lgtm

google-oss-prow[bot] commented 12 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dorileo, gonzoua

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/guest-oslogin/blob/master/OWNERS)~~ [dorileo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment